tfabris / CrowCam

A set of Bash scripts to control and maintain a YouTube live cam from a Synology NAS.
GNU General Public License v3.0
3 stars 3 forks source link

Renaming a video while it's still livestreaming will produce errors. #82

Closed tfabris closed 5 months ago

tfabris commented 5 months ago

There is a piece of code (described in issue #27) which tries to ensure that the video is named "CrowCam" before we try fixing up the stream name/key. I don't think this is needed any more.

The issue:

The checking of the video's title was supposed to be some kind of safety feature to prevent us from switching the stream key to some other video. But I don't think that's needed. At the time the check is performed, we have retrieved the stream that was bound to the current live broadcast. If we're not looking at the right video at that point, there's a bunch of other problems which would arise first.

I don't think this needs to be checked and I don't think the error messages are useful. Remove the check and see if things work OK in the long term.

tfabris commented 5 months ago

I have commented out the code which checks the stream title before allowing the stream key fix: 00f921f

Live with this for a little while and see if it produces any ill effects.