tfaehse / DashcamCleaner

Censor identifiable information in videos, in particular dashcam recordings in Germany.
GNU Affero General Public License v3.0
134 stars 27 forks source link

add shebang, change argparse, add pre-commit-hooks #12

Closed joshinils closed 2 years ago

joshinils commented 2 years ago

i had no clue what the positional arguments were there to do, so i tried to figure it out by trial and error. some have obvious limits and ranges, some can have sensible defaults, some i could not figure the limits or sensible defaults by looking at the code or trial and error.

joshinils commented 2 years ago

i did not add mypy, most of the code would have to change to include typehints

tfaehse commented 2 years ago

Thank you for your contribution! The CLI looks much, much nicer now. All I changed was snake case for the named arguments and the mypy file.

I don't think mypy would be a significant addition, since all the heavy lifting already runs in optimised code anyway:

image

The profiler shows that almost all time is spent finding faces/plates, the only other somewhat significant contributions are blurring and reading frames. Both happen in OpenCV, in C++.

joshinils commented 2 years ago

no worries about mypy, i just copied all the files form another python project of mine.

i was a little lost about all the arguments for the cli, hence why i changed all of these things.