search

tfaehse / DashcamCleaner

Censor identifiable information in videos, in particular dashcam recordings in Germany.
GNU Affero General Public License v3.0
131 stars 27 forks source link

total amount of frames in progress bar is approximated #27

Open joshinils opened 2 years ago

joshinils commented 2 years ago

https://github.com/tfaehse/DashcamCleaner/blob/36833e2ef19b9bcb364dd5af3e6f3e3144ea105d/dashcamcleaner/src/blurrer.py#L134-L143

this sometimes leads to the progress bar never being closed (properly)

see https://stackoverflow.com/questions/2017843/fetch-frame-count-with-ffmpeg for potential solution (idk if the current codebase can get the total framecount without looking at the file in another subprocess)

tfaehse commented 2 years ago

Can you send me the file? I'd like to check what information is there, the length estimation is an ugly workaround indeed. "Proper" input files have a length attribute anyway, but unfortunately it's not always set...