tfaughnan / artoo

Barebones IRC bot / astromech droid (WIP 🚧)
GNU General Public License v3.0
1 stars 4 forks source link

refact(plugins): each plugin in a separate pkg #7

Closed rafaelrubbioli closed 2 years ago

rafaelrubbioli commented 2 years ago

For better readability and usage, each plugin is now in a subpackage of the plugin pkg.

closes https://github.com/tfaughnan/artoo/issues/4

tfaughnan commented 2 years ago

This looks good. Can you also rename the pattern and handler for each of the two plugins to just be Pattern and Handler?

E.g.echo.EchoPattern and echo.EchoHandler -> echo.Pattern and echo.Handler

rafaelrubbioli commented 2 years ago

@tfaughnan sure! do you also think is a good idea to rename internal names such as openaiRespPayload to respPayload?

tfaughnan commented 2 years ago

Yes those should be renamed to remove the redundant prefix -- good catch.

rafaelrubbioli commented 2 years ago

@tfaughnan done!

tfaughnan commented 2 years ago

LGTM, thanks!