tfausak / rattletrap

:car: Parse and generate Rocket League replays.
https://hackage.haskell.org/package/rattletrap
MIT License
150 stars 21 forks source link

Failed Replays #62

Closed Aurmeilius closed 6 years ago

Aurmeilius commented 6 years ago

Some replays fail to be parsed, yet are working in Rocket League. These replays were downloaded from RocketLeagueReplays. I figured they would help.

Failed Replays.zip

tfausak commented 6 years ago

Thanks for reporting this! Is there anything unusual about these replays?

These are the errors that I see with Rattletrap v4.0.1:

1515484916.7002666: could not get attribute map for CompressedWord {compressedWordLimit = 2047, compressedWordValue = 409}
1515484919.3686504: could not get name for index Word32le {word32leValue = 2176450559}
1515484923.7188919: could not get name for index Word32le {word32leValue = 24574}
1515484925.4521036: could not get name for index Word32le {word32leValue = 100721866}
1515484927.6516037: could not get object name for id Word32le {word32leValue = 31463118}
1515484941.5710928: could not get name for index Word32le {word32leValue = 276464145}
1515484943.736464: could not get name for index Word32le {word32leValue = 3117108431}
1515484947.4916337: could not get attribute map for CompressedWord {compressedWordLimit = 2047, compressedWordValue = 92}
1515484967.8259037: could not get class name for object Str {strValue = "Archetypes.Ball.Ball_BasketBall"}
1515484981.1860275: could not get attribute map for CompressedWord {compressedWordLimit = 2047, compressedWordValue = 524}
1515484984.0611174: could not get attribute map for CompressedWord {compressedWordLimit = 2047, compressedWordValue = 1280}
1515484986.1581845: could not get name for index Word32le {word32leValue = 109100841}
1515517569.313021: could not get name for index Word32le {word32leValue = 3624467457}
Aurmeilius commented 6 years ago

One was in hoops, one was in rocket labs. The others I believe are players mixed in with bots, and the bots would be subbed in and out sometimes. Nothing too unexpected.

tfausak commented 6 years ago

The replay 1515484967.8259037 fails because Rattletrap is missing a class for the Archetypes.Ball.Ball_BasketBall attribute. That should be pretty easy to fix.

All of the other replays fail after parsing a TAGame.PRI_TA:PlayerHistoryKey attribute. That means these replays contain Nintendo Switch players and my work in #60 wasn't quite right. Might take a little longer to fix.

tfausak commented 6 years ago

This is not completely fixed yet. See https://github.com/tfausak/rattletrap/pull/63#issuecomment-357474581.

andrewchae commented 6 years ago

Hey Taylor, here are the Switch IDs I'm getting from Rocket League for these replays:

1515484916.7002666.replay: 9951646033564027494
1515484919.3686504.replay: 5427179077552520318
1515484923.7188919.replay: 16905126163554889974
1515484925.4521036.replay: 8001770748285098156
1515484927.6516037.replay: 3125957839636147968
1515484941.5710928.replay: 13894212204523533515
1515484943.736464.replay: 4737493435786438694 and 47698415325980233
1515484947.4916337.replay: 6994403759523956968
1515484981.1860275.replay: 18428490643497068053
1515484984.0611174.replay: 12252438204628757460
1515484986.1581845.replay: 12692403298873131416, 13763210433912576132, 11799125558393306091, and 9845986385505292683
1515517569.313021.replay: 13691273858586026578

Hope this helps!

tfausak commented 6 years ago

Thanks! That should help me actually parse the bits in the Switch IDs. I’ll get around to it soon :)

tfausak commented 6 years ago

Here's a replay with a secondary title that Rattletrap can't parse: 75CE61FB421D5A847A4C3AB7C6C4E884.zip

cjsauer commented 6 years ago

Hey @tfausak, thank you for working on this awesome tool. I have a replay here of a standards ranked match that is also failing to parse. Nothing too unusual, but it might be worth noting that the losing team forfeit the match with about a minute left.

Relevant (and only) error:

rattletrap-4.0.6-linux: could not get name for index Word32le {word32leValue = 229379}

You can see above that I'm using rattletrap-4.0.6 on Linux (Ubuntu).

54C25B2811E839CEDFE23D963F87899B.replay.zip

tfausak commented 6 years ago

Thanks for reporting that! Would you mind making a new issue for it? I think it's a different failure mode than the one described here.

cjsauer commented 6 years ago

Sure thing. Moved to here: https://github.com/tfausak/rattletrap/issues/70