search

tfausak / rattletrap

:car: Parse and generate Rocket League replays.
https://hackage.haskell.org/package/rattletrap
MIT License
150 stars 21 forks source link

Can't read replays from Rocket League v1.43 #68

Closed andrewchae closed 6 years ago

andrewchae commented 6 years ago

Getting this error: rattletrap-4.0.5-windows.exe: don't know how to get attribute value Str {strValue = "TAGame.GameEvent_TA:ReplicatedRoundCountDownNumber"}

tfausak commented 6 years ago

Thanks for reporting this! I will hopefully find some time to look into this soon.

It looks like my competitor already added support 😄 https://github.com/jjbott/RocketLeagueReplayParser/commit/41d1cac7ef2e592ded0d13e1940fe5a1065fddca

tfausak commented 6 years ago

Here's an example of a replay that fails to parse with Rattletrap 4.0.6: 946FA4514750AF5835F0B4BD8ACF1188.zip

andrewchae commented 6 years ago

Hey Taylor, I believe you're missing a few attributes,

"TAGame.GameEvent_Soccar_TA:ReplicatedServerPerformanceState", AttributeTypeByte "TAGame.GameEvent_Soccar_TA:SeriesLength", AttributeTypeInt "TAGame.PRI_TA:PrimaryTitle", AttributeTypeInt "TAGame.PRI_TA:ReplicatedWorstNetQualityBeyondLatency", AttributeTypeByte "TAGame.PRI_TA:SecondaryTitle", AttributeTypeInt

I'll try to find some replays that got these in there for you!

tfausak commented 6 years ago

Thanks for the heads up! I'm running the changes from #69 against all the new replays I have locally. I haven't failed to parse any replays yet, but I only have a couple from the new tournament mode. I'm not sure if I have any that have the replicated ping information.

I'm pretty sure the primary and secondary title attributes are from an older patch. I just haven't updated Rattletrap to handle them yet. See https://github.com/tfausak/rattletrap/pull/63#issuecomment-357474581.

tfausak commented 6 years ago

Here's one with the series length that fails to parse: A09EE0E84453846514DE458AAC434AE3.zip

tfausak commented 6 years ago

I still don't have any replays with the TAGame.GameEvent_Soccar_TA:ReplicatedServerPerformanceState attribute. Can you provide one?

tfausak commented 6 years ago

I'm reopening this since ReplicatedServerPerformanceState attributes aren't handled yet. If anyone can provide a replay with that attribute, I will happily add it to the test suite and fix it.

andrewchae commented 6 years ago

Here's one with TAGame.GameEvent_Soccar_TA:ReplicatedServerPerformanceState. Sorry for being late!

92A64EE24C0BB012A477128C99FB5821.zip

Slokh commented 6 years ago

Here's another replay with TAGame.GameEvent_Soccar_TA:ReplicatedServerPerformanceState _2.zip

tfausak commented 6 years ago

Thanks y'all! I will get around to this soon — promise 😄 If you feel comfortable opening a PR, I would also accept that. Thanks!

tfausak commented 6 years ago

Should be fixed in 4.0.8. Thanks, y'all!