tfausak / splint

:newspaper_roll: HLint as a GHC source plugin.
https://hackage.haskell.org/package/splint
ISC License
31 stars 1 forks source link

Fix bugs when loading settings #4

Closed tfausak closed 4 years ago

tfausak commented 4 years ago

While testing Splint on some larger projects, I noticed I could reliably get a crash if I ran GHC with -j. Eventually I tracked the problem down to the call to argsSettings. This made me discover two bugs:

This PR fixes the crash, prevents two threads from loading the same settings at the same time, and allows files to use different settings.

tfausak commented 4 years ago

I opened an issue for the GHC crash that caused me to look into this in the first place: https://gitlab.haskell.org/ghc/ghc/issues/18261