search

tfgm / sbedecoder

Python based Simple Binary Encoding (SBE) decoder
MIT License
75 stars 45 forks source link

Support for python3 #34

Closed mehazardtfgm closed 6 years ago

tfgm-bud commented 6 years ago

@mehazardtfgm There are a few additional minor things I think need changing.

1) The division here https://github.com/tfgm/sbedecoder/blob/a1f2e6ee81db491aa1a3b7fb761e0619d0838262/mdp/orderbook/orderbook.py#L117 should be //

2) Need to add six to the install_requires in setup.py and to requirements.txt

3) The version parameter has been removed from ArgumentParser() in python 3. I'd just remove the version parameter from our code where it is specified in: scripts/mdp_decoder.py, scripts/mdp_book_builder.py and generator/sbe_class_generator.py

tfgm-bud commented 6 years ago

Oh, can you also update the README and add the python 3 programming language classifiers to the setup.py file?

tfgm-bud commented 6 years ago

@mehazardtfgm sorry, one more thing. Please add python 3.6 to the .travis.yml file.