tfhe / spqlios-arithmetic

spqlios arithmetic library for FHE and post-quantum crypto
Apache License 2.0
13 stars 0 forks source link

CONTRIBUTING #10

Closed ngama75 closed 1 year ago

sguaschsbt commented 1 year ago

@ngama75 , @MGeorgie added some comments and suggestions for rewording. I understand the information for external collaborators will be added in another PR right? Should we add something about enabling the WARNING_PARANOID flag when developing?

ngama75 commented 1 year ago

That's a good idea, we should add:

sguaschsbt commented 1 year ago

That's a good idea, we should add:

  • ensure that the source-code is formatted according to the clang-format style
  • compiles with -DWARNING_PARANOID
  • runs the unittests and integration tests locally
  • has the flag check-on-arm64 on the Pull Request (Maintainer will set it after the review)

I saw the changes! did you want to add something about unit tests at the end? I didn't see that

ngama75 commented 1 year ago

No, I think the current page already covers it. We will revisit if we add long tests that are not covered by CI.

sguaschsbt commented 1 year ago

No, I think the current page already covers it. We will revisit if we add long tests that are not covered by CI.

Sounds good :D