Closed ngama75 closed 1 year ago
That's a good idea, we should add:
That's a good idea, we should add:
- ensure that the source-code is formatted according to the clang-format style
- compiles with -DWARNING_PARANOID
- runs the unittests and integration tests locally
- has the flag check-on-arm64 on the Pull Request (Maintainer will set it after the review)
I saw the changes! did you want to add something about unit tests at the end? I didn't see that
No, I think the current page already covers it. We will revisit if we add long tests that are not covered by CI.
No, I think the current page already covers it. We will revisit if we add long tests that are not covered by CI.
Sounds good :D
@ngama75 , @MGeorgie added some comments and suggestions for rewording. I understand the information for external collaborators will be added in another PR right? Should we add something about enabling the WARNING_PARANOID flag when developing?