search

tfjgeorge / nngeometry

{KFAC,EKFAC,Diagonal,Implicit} Fisher Matrices and finite width NTKs in PyTorch
https://nngeometry.readthedocs.io
MIT License
206 stars 20 forks source link

Jaco revamp #34

Closed tfjgeorge closed 2 years ago

tfjgeorge commented 2 years ago

Splits Jacobian logic into the main Jacobian class, and *Factory static classes where grad computations are defined

codecov-commenter commented 2 years ago

Codecov Report

Merging #34 (7758d9c) into master (e2b3b26) will increase coverage by 0.28%. The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   93.05%   93.34%   +0.28%     
==========================================
  Files          24       27       +3     
  Lines        3010     3200     +190     
==========================================
+ Hits         2801     2987     +186     
- Misses        209      213       +4
Impacted Files Coverage Δ
tests/tasks.py 84.24% <85.48%> (-3.13%) :arrow_down:
nngeometry/layercollection.py 89.07% <92.30%> (+1.28%) :arrow_up:
nngeometry/generator/jacobian/__init__.py 98.40% <97.14%> (ø)
nngeometry/generator/jacobian/grads.py 100.00% <100.00%> (ø)
nngeometry/layers.py 100.00% <100.00%> (ø)
tests/test_jacobian.py 99.70% <100.00%> (+<0.01%) :arrow_up:
tests/test_layers.py 100.00% <100.00%> (ø)
tests/utils.py 85.71% <100.00%> (+1.50%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2b3b26...7758d9c. Read the comment docs.