tfjgeorge / nngeometry

{KFAC,EKFAC,Diagonal,Implicit} Fisher Matrices and finite width NTKs in PyTorch
https://nngeometry.readthedocs.io
MIT License
203 stars 20 forks source link

changes to linalg.solve and linalg.eigh #57

Closed tfjgeorge closed 1 year ago

tfjgeorge commented 1 year ago

Recent torch (2.0.1?) deprecated torch.solve and torch.symeig, this PR now uses torch.linalg.* methods

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.54 :tada:

Comparison is base (ba2dcb1) 93.44% compared to head (b78eec3) 93.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #57 +/- ## ========================================== + Coverage 93.44% 93.98% +0.54% ========================================== Files 29 29 Lines 3386 3427 +41 ========================================== + Hits 3164 3221 +57 + Misses 222 206 -16 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `93.98% <100.00%> (+0.54%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+George#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/tfjgeorge/nngeometry/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+George) | Coverage Δ | | |---|---|---| | [nngeometry/object/fspace.py](https://app.codecov.io/gh/tfjgeorge/nngeometry/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+George#diff-bm5nZW9tZXRyeS9vYmplY3QvZnNwYWNlLnB5) | `75.00% <100.00%> (+12.77%)` | :arrow_up: | | [nngeometry/object/pspace.py](https://app.codecov.io/gh/tfjgeorge/nngeometry/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+George#diff-bm5nZW9tZXRyeS9vYmplY3QvcHNwYWNlLnB5) | `94.16% <100.00%> (+1.84%)` | :arrow_up: | | [tests/test\_jacobian.py](https://app.codecov.io/gh/tfjgeorge/nngeometry/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Thomas+George#diff-dGVzdHMvdGVzdF9qYWNvYmlhbi5weQ==) | `99.72% <100.00%> (+0.03%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.