tflo / PetWalker

WoW Retail addon. Automatically restores your lost companion pet or/and periodically auto-summons a new one from a configurable pool. Can be set to work globally (same pet(s) for all alts), or per char.
GNU General Public License v3.0
3 stars 0 forks source link

PetWalker cancelling my spell cast? #10

Closed tflo closed 2 months ago

tflo commented 3 months ago

This issue is transferred from the CurseForge comments, posted by archkerberus, 9 May 2024

Trying to detect which addon (if any) is 'cancelling' my casts, and just disabled this one to test, and the same cast that was being interrupted isn't anymore. Could be it or not, who knows. An example: you're in a mount, in the Emerald Dream, you drop on a soil to plant a seed, and start the ~10s cast. The above stopped happening.

Is there a way to 'prevent' the addon from spawning a pet if the character is already casting something. I've tested the timers for the pet spawn, and the character actually 'moves' in place, like if dropping something, much like when we summon a BPet manually. Dunno if it's the random pet timer we can set or by default, but if there'd be a way to 'hold' the summon if the character is casting something, I'd be thankfull ;).

If needed, I can send this to the 'issues' sub-link.

tflo commented 3 months ago

Basically the only event that triggers a pet summon from PW (if the conditions are met) is the PLAYER_STARTED_MOVING event. This is also why I don't check for spells in progress: the vast majority of (non-instant) spells are interrupted when you start moving anyway. I just tested with planting a seed, and yes, it is also interrupted when I start moving (with PW disabled).

So, honestly, I'm not sure what you're experiencing here.

Is it possible that you are confusing spell interruption with a Global Cooldown (GCD) conflict? Check out this section of the manual to see what I mean. But a GCD cannot interrupt a cast, it can only prevent you from starting a cast, until the GCD is over.

If this is a GCD thing, there is nothing I can do about it. One thing that can reduce the chance of GCD conflicts is to allow pet summoning also while mounted for Skyriding[^1]:

  1. Print PW’s status with /pw s.
  2. If it says “Automatic summoning while mounted for Skyriding is not allowed”, then allow it with the /pw sr toggle.[^2]

This allows PW to summon already when you move before you dismount, so there is a better chance that the GCD will be over when you want to cast something else.

[^1]: When mounted and in Steady Flight mode, summoning is always allowed (on ground, ofc).

[^2]: Text and command were recently changed (v2.2.0). If you use an older version, the command is /pw r.

tflo commented 2 months ago

Closed due to no user response after 1 month.