search

tflori / angular-translator

translation module for angular
https://tflori.github.io/angular-translator/
MIT License
21 stars 6 forks source link

Update to latest angular #16

Closed BorntraegerMarc closed 7 years ago

BorntraegerMarc commented 7 years ago

Peer dependencies are still for 2.*. Would be good to update to 4.* and rename the project to angular-translator maybe. #itsJustAngular :)

tflori commented 7 years ago

4.x? Yesterday someone wrote a comment and mentione that this is not working in ng5. first I thought it was a typo. what they want us to do, to force everyone to update their code to the latest Android version, or to stop peer dependencies giving a version?

we can not force everyone that is using angular2-translator to upgrade to ng4.. I think I will remove peer dependencies or just have @angular/core: *

BorntraegerMarc commented 7 years ago

@tflori didn't get the Android reference but if the peer dependency is removed then it seems good :) thx!

tflori commented 7 years ago

the rename comes with next version - every links will change and this may destroy your setup.. i created another issue for this

tflori commented 7 years ago

I hope it works.. as the dev dependencies are still 2.*. I will change them for angular-translator@2.0