search

tflori / angular-translator

translation module for angular
https://tflori.github.io/angular-translator/
MIT License
21 stars 6 forks source link

Version 2.4 Released #40

Closed tflori closed 5 years ago

tflori commented 7 years ago

Hi,

I don't want to set up a board for this small project. Anyway I really like your feedback.

If you have questions, feature requests or other issues - please open a new issue. If you have feedback for the new release feel free to post a comment.

Thanks for all the stars :+1: :smile:

Best regards

tflori commented 7 years ago

It was easier as I toughed to invent pipes. So soon I will release version 2.1.

If you have any other features you want to see in version 2.1 please let me know now.

tflori commented 7 years ago

now we have version 2.1 with pipes in translations

BorntraegerMarc commented 7 years ago

Love it!!! Only thing I wanted to mention is that maybe we could replace the translator.translate('TEXT') from returning a promise to an observable. That way the UI would always automatically update when TranslatorContainer changes the language :) But I think we already had that topic once :)

tflori commented 7 years ago

We had a different topic once (was about the observable languageChanged not languageLoaded).

It's a good idea to have an observable for each translate. Maybe with a third method observe('TEXT'). I rather don't want to change the interface completely (everyone will have to update every call to translate).

I will have to think about how this could be implemented. Please open an issue for this feature request.

BorntraegerMarc commented 7 years ago

Sounds good, thx :) Opened up https://github.com/tflori/angular-translator/issues/44

mouragz commented 6 years ago

Can I ask if this new release work with new version of angular^5.0.0 ? @tflori

BorntraegerMarc commented 6 years ago

@mouragz nothing changed from pipes in angular 5. I think it'll work just fine

mouragz commented 6 years ago

I'm trying to update to angular5 but i have an error say "ERROR TypeError: Cannot read property 'annotations' of undefined at PipeResolver.resolve" when i add this line of code in app.component.ts file constructor( private translator: Translator,private translatorContainer: TranslatorContainer) { } @BorntraegerMarc @tflori

tflori commented 6 years ago

@mouragz thanks for your contribution. Currently I don't get the tests to run with angular 5.0.1 it seems this will take more time.

:cry: every half year a new version with so much incompatible code - it's frustrating.

tflori commented 6 years ago

@mouragz I opened #64 and #65 to solve the problems with angular 5 - hopefully it still works in angular 4 and 2