tflori / angular-translator

translation module for angular
https://tflori.github.io/angular-translator/
MIT License
21 stars 6 forks source link

Update documentation #57

Closed ziemerz closed 7 years ago

ziemerz commented 7 years ago

The documentation here is not up to date.

Under the headline "Setup angular module"

TranslatorModule.forRoot({
      defaultLang: "de",
      providedLangs: [ "de", "en" ],
      detectLanguageOnStart: false
    })

Should be:

TranslatorModule.forRoot({
      defaultLanguage: "de",
      providedLanguages: [ "de", "en" ],
      detectLanguageOnStart: false
    })

If they're not, the module fails to set the appropriate language when configuring the language elsewhere in the application and will stay in English.

tflori commented 7 years ago

Thanks for this finding. I found it also on two other places and also detectLanguageOnStart changed to detectLanguage.

this commit solved it: https://github.com/tflori/angular-translator/commit/8579fd83cc3f4ae61115ea4790b4fae662b612d0