Nested objects are now allowed for translations.

tflori / angular-translator

translation module for angular

https://tflori.github.io/angular-translator/

MIT License

21 stars 6 forks source link

Nested objects are now allowed for translations. #6

Closed BorntraegerMarc closed 7 years ago

BorntraegerMarc commented 7 years ago

Resolves https://github.com/tflori/angular2-translator/issues/4

coveralls commented 7 years ago

Coverage increased (+0.02%) to 97.877% when pulling b4128cee66548dea4b9c30ae6561f01025883fa3 on BorntraegerMarc:feature/nested-objects into ad015884b4733b01401e4bc6fb24e6fbca843cb6 on tflori:master.

tflori commented 7 years ago

It's another interesting approach but have you tried accessing them? because I think that TranslateLoader::instant('app.loginText') can not access this objects.

But I like your tests (except the things tslint mentioned).

BorntraegerMarc commented 7 years ago

@tflori yup, I'm fixing them now

BorntraegerMarc commented 7 years ago

OK, I'm merging your logic and my tests together 😄

coveralls commented 7 years ago

Coverage increased (+0.01%) to 97.872% when pulling ac18d24c883a232b95f28b686639b518cb72c87f on BorntraegerMarc:feature/nested-objects into ad015884b4733b01401e4bc6fb24e6fbca843cb6 on tflori:master.

BorntraegerMarc commented 7 years ago

OK @tflori Everything is included now. Inclusive tests... Could you merge the PR and publish a new version? That would be charmin' 😄