search

tfmonk / Accountant

GNU General Public License v3.0
3 stars 0 forks source link

AH profit goes to mail section #6

Closed razorbladehnt closed 1 year ago

razorbladehnt commented 1 year ago

On RU client every profit from AH goes to mail section instead of AH

Steps to recreate 1 install ru locale for Wow 2 connect to ru realm 3 sell something on AH 4 loot mailbox

Screen from RU client 123

And this is a screen from EU client (expected behaviour) eu

tfmonk commented 1 year ago

its, possible an issue with localisation in regards to the mail names for auction house emails being different between the languages on EU/US clients its looking for the mail string "Auction successful:" or "Outbid" to determine if its an auction mail to allocate the gold to the right category but in Russian it is something different..

To fix it would need help creating an Russian locale file and translating the string

razorbladehnt commented 1 year ago

"Auction successful:" will be "Аукцион состоялся:" Not sure how "Outbid:" will be translated I made some bids if any of them will be outbided i'll add correct translation here

tfmonk commented 1 year ago

Thanks, I will look at adding some additional localization files for the various locales available for wow, which will allow strings within Accountant to start being translated so functionality will work

razorbladehnt commented 1 year ago

Outbid in RU locale Ваша ставка перебита (предмет: %itemname%)

tfmonk commented 1 year ago

@razorbladehnt thanks there should be an alpha version going up on curse shortly with localization enabled which should hopefully fix the issue.

I've used the localisations that were provided on curse forge, if the issue still persists, you could update the strings in the ruRu.lua file and let me know which one fixes it and ill make the change

razorbladehnt commented 1 year ago

oof A bit broken after update =) https://pastebin.com/HyGk98ZS with these changes it works like expected but look a little bit funky Безымянный I'll try to translate the rest after the raid

tfmonk commented 1 year ago

its due to UnitFactionGroup API returning English for the faction name, I did do some testing but looks like the languages i used didn't have this converted, I've tried Russian and its now working again.

I've pushed a fix out which should be available shortly