tfoote / rosidl_typesupport_protobuf

Middleware agnostic ros2 static typesupport which uses Protobuf for serialization/deserialization.
Apache License 2.0
0 stars 0 forks source link

Visibility control is documented as necessary for the user to include #12

Closed tfoote closed 11 months ago

tfoote commented 11 months ago

I noticed that the visibility control was added into the documentation. I'd like to double check that this is either:

1) Not necessary and we can remove it from the documentation 2) If it is necessary add it to the generated header files in the appropriate places so that it becomes not necessary and then remove it from the documentation.

tfoote commented 11 months ago

Also potentially clean up type declaration that might not be necessary: https://github.com/tfoote/rosidl_typesupport_protobuf/pull/9/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R27

gdiaz-guevara commented 11 months ago

In this branch, I added the generated header file in the appropriate places and also removed it from the documentation.

Also, I cleaned up the documentation and removed the type declaration that is not necessary.