tfoote / rosidl_typesupport_protobuf

Middleware agnostic ros2 static typesupport which uses Protobuf for serialization/deserialization.
Apache License 2.0
0 stars 0 forks source link

generated typesupport_protobuf (c and cpp) doesn't pass clang tidy #13

Open tfoote opened 11 months ago

tfoote commented 11 months ago

I was able to get it to run on the standard ROS 2 CI builds at: https://ci.ros2.org/job/ci_linux/19980/

It used https://github.com/ros2/ci/tree/tfoote/protobuf_dependency and https://gist.github.com/tfoote/12dc8438d85a4a3f94dd3cf982d83486#file-supplimental-repo

I see about 1200 warnings

There are a lot of instances of : missing initializer for member ‘rosidl_message_type_support_t::get_type_hash_func’ [-Wmissing-field-initializers] 124 | }; | ^

missing initializer for member ‘rosidl_message_type_support_t::get_type_description_func’ [-Wmissing-field-initializers]

and

missing initializer for member ‘rosidl_message_type_support_t::get_type_description_sources_func’ [-Wmissing-field-initializers]

Whenever handles are created such as: static rosidl_message_type_support_t _GoalInfo__handle = { or static rosidl_message_type_support_t _CancelGoal_Request__handle = {

I think these might be new values to extend the template.