tfoote / rosidl_typesupport_protobuf

Middleware agnostic ros2 static typesupport which uses Protobuf for serialization/deserialization.
Apache License 2.0
0 stars 0 forks source link

Rosidl cli generate proto test #25

Open gonzodepedro opened 8 months ago

gonzodepedro commented 8 months ago

Adds tests for rosidl cli generate typesupports for protobuf

gonzodepedro commented 8 months ago

Get paths from get_package_share_directory

      package_share_path = pathlib.Path(
            get_package_share_directory('rosidl_typesupport_protobuf_c'))
gonzodepedro commented 8 months ago

Check that it is creating typeadapters

gonzodepedro commented 8 months ago

Both comments are fixed now

tfoote commented 8 months ago

Current failure:

  CMake Error at /__w/rosidl_typesupport_protobuf/rosidl_typesupport_protobuf/ros_ws/install/rosidl_typesupport_protobuf_c/share/rosidl_typesupport_protobuf_c/cmake/rosidl_typesupport_protobuf_c_generate_interfaces.cmake:41 (add_library):
    No SOURCES given to target:
    rosidl_generator_py_custom__rosidl_typesupport_protobuf_c
  Call Stack (most recent call first):
    /__w/rosidl_typesupport_protobuf/rosidl_typesupport_protobuf/ros_ws/install/ament_cmake_core/share/ament_cmake_core/cmake/core/ament_execute_extensions.cmake:48 (include)
    /__w/rosidl_typesupport_protobuf/rosidl_typesupport_protobuf/ros_ws/install/rosidl_cmake/share/rosidl_cmake/cmake/rosidl_generate_interfaces.cmake:286 (ament_execute_extensions)
    CMakeLists.txt:56 (rosidl_generate_interfaces)

This looks like it's trying to compile the library before it's generated. We need a dependency in CMake to prevent this.

gonzodepedro commented 8 months ago

This PR must be compiled using this repos file.