tforkmann / Feliz.ReactFlow

Feliz React Binding for ReactFlow
https://tforkmann.github.io/Feliz.ReactFlow/
Apache License 2.0
32 stars 3 forks source link

Nuget is not fable compatible #1

Closed Zaid-Ajaj closed 3 years ago

Zaid-Ajaj commented 3 years ago

Hi @tforkmann it seems that the nuget package doesn't include any Fable sources which means it will break when installed from a project

2021-04-09 12_26_19-C__Users_zaidn_Downloads_feliz reactflow 0 1 4

You need to include the sources using

<ItemGroup>
    <Content Include="*.fsproj; *.fs; *.js;" Exclude="**\*.fs.js" PackagePath="fable\" />
</ItemGroup>

Also the dependency should be a non-dev dependency so you can remove DevDependency="true" from the femto metadata Also this packages take too many nuget packages as dependencies

2021-04-09 12_29_33-NuGet Gallery _ Feliz ReactFlow 0 1 4

You only need Feliz as a dependency (update paket.references to only require Feliz).

Preferably the target framework can be netstandard2.0 for maximum compatibility with Fable projects that aren't using dotnet 5.0

tforkmann commented 3 years ago

Hi Zaid,

will try to fix over the weekend!

Best,

Tim

tforkmann commented 3 years ago

Should be fine now. image

Closing with 7e22576