search

tfoxy / graphene-django-optimizer

Optimize database access inside graphene queries
MIT License
428 stars 84 forks source link

[WIP] Fixed reverse related is missing required field #14

Closed yardensachs closed 5 years ago

yardensachs commented 5 years ago

I can't get the tests to pass, i'm not sure if its an issue, or just a test adjustment. I would be happy to get some help.

Fixes #13

dex4er commented 5 years ago

This patch fixes the tests: https://github.com/yardensachs/graphene-django-optimizer/pull/1

@tfoxy I use this module because graphene-django is useless for queries with reverse related fields, or at least it requires a lot of prefetch_related hints that might be unnecessary for most cases.

Please accept this pull request because it makes graphene-django-optimizer usable as it should be in first place.

tfoxy commented 5 years ago

Hi! Sorry for not paying attention to this. I'm not using this anymore so it was hard for me to get interest in this. I have a long weekend starting from today, so hopefully I can solve all the issues and PRs.

Check the review comments!

dex4er commented 5 years ago

This is a really good PR. I didn't realized that this case wasn't handled.

Can you check the comment about the commented line and the comment about the 10 items?

I'm commenting here and applied changes for #16 because I fixed this #14 PR of @yardensachs in my own fork.