search

tfoxy / graphene-django-optimizer

Optimize database access inside graphene queries
MIT License
428 stars 84 forks source link

Connections ignoring hints #34

Open OmegaDroid opened 5 years ago

OmegaDroid commented 5 years ago

Hi again,

I noticed another issue where related relay connections were ignoring optimization_hints due to the resolver being nested inside partials so I've updated it to search down the partials chain to find the hints.

codecov-io commented 5 years ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.29%. Comparing base (e6bede5) to head (3ebc788). Report is 40 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #34 +/- ## ========================================== - Coverage 93.54% 93.29% -0.26% ========================================== Files 6 6 Lines 310 313 +3 ========================================== + Hits 290 292 +2 - Misses 20 21 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

berkcoker commented 3 years ago

^^ would be great if this was merged... @tfoxy

k1wdel commented 3 years ago

we've implemented a similar solution to solve the same problem in our project. would be nice if it gets in 🙏