Apply black - Githubissues

tfoxy / graphene-django-optimizer

Optimize database access inside graphene queries

MIT License

428 stars 84 forks source link

Apply black #69

Closed ulgens closed 3 years ago

ulgens commented 3 years ago

Black only version of https://github.com/tfoxy/graphene-django-optimizer/pull/62

ulgens commented 3 years ago

@tfoxy ~I'm not sure why travis is not triggered, I can use some help to fix it.~ Apparently it works but didn't show as a check yet, not sure why.

ulgens commented 3 years ago

Other small stuff i found, thinking they relates to this topic:

CI can be and should be IMO moved to Github Actions.
We need a CI step to keep styling consistent.
We need a part in documentation about development.

tfoxy commented 3 years ago

Hi @ulgens! Thanks for the PR. I'm trying to fix the travis configuration. In the meantime, can you add black to the travis lint stage? Something like: black --check graphene_django_optimizer/ tests/ setup.py. Or maybe we can use the pyproject.toml file to configure the files.

ulgens commented 3 years ago

Hey man, I can add it as a CI step but I was trying to keep this one short if that's ok for you. We can handle that in a different PR.

tfoxy commented 3 years ago

Ok, seems good. Will merge then.