search

tfoxy / graphene-django-optimizer

Optimize database access inside graphene queries
MIT License
428 stars 84 forks source link

Code cleanup #7

Closed Pacu2 closed 6 years ago

Pacu2 commented 6 years ago

The _optimize_gql_selections was over 100 lines long, I've cleaned it up a little bit, taking parts of it as separate functions.

Unfortunately, running tests does not work for me, if there's no CI here to run them, I'll have to double check they're passing, before accepting those changes.

codecov-io commented 6 years ago

Codecov Report

Merging #7 into master will decrease coverage by 0.29%. The diff coverage is 97.61%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #7     +/-   ##
=========================================
- Coverage   97.37%   97.08%   -0.3%     
=========================================
  Files           5        5             
  Lines         267      274      +7     
=========================================
+ Hits          260      266      +6     
- Misses          7        8      +1
Impacted Files Coverage Δ
graphene_django_optimizer/query.py 96.61% <97.61%> (-0.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 28b3411...bb6e554. Read the comment docs.

tfoxy commented 6 years ago

Really glad to see this PR! It was a much needed refactor. Tests seems to pass just fine. Thank you for your time!