search

tfoxy / graphene-django-optimizer

Optimize database access inside graphene queries
MIT License
427 stars 86 forks source link

Update dependencies for non-beta graphene-django v3 release #85

Open sjdemartini opened 1 year ago

sjdemartini commented 1 year ago

graphene-django released a non-beta version of v3 in Sept 2022 (https://github.com/graphql-python/graphene-django/releases/tag/v3.0.0).

This updates the dev dependencies accordingly, to no longer point to the beta releases.

This PR is meant as demonstration only, since in its current form, graphene-django-optimizer unfortunately actually does not properly SQL-optimize nested fields (among other things), when used with the latest version of graphene-django. This can be seen in that several tests related to SQL optimization now fail after this version upgrade, such as test_should_select_nested_prefetch_and_select_related_fields. Now resolved with graphene-django 3.0.2.

sjdemartini commented 1 year ago

With the latest commit to bump to the newly-released graphene-django 3.0.2 https://github.com/graphql-python/graphene-django/releases/tag/v3.0.2 (which includes this https://github.com/graphql-python/graphene-django/pull/1401), the performance-related tests are now passing.

The only test that still fails is the unrelated one mentioned here https://github.com/tfoxy/graphene-django-optimizer/pull/83#issue-1319467642, for which that PR has added a workaround.