tfoxy / graphene-django-optimizer

Optimize database access inside graphene queries
MIT License
428 stars 84 forks source link

Add GitHub Actions #95

Closed tfoxy closed 1 year ago

tfoxy commented 1 year ago

Based on the workflows in graphql-python/graphene-django/.github/workflows, but adapted to use the same versions and tools that we were already using in Travis CI so that we can make sure everything works as before. Removed Python 3.6 as it's not supported in the latest version of Ubuntu in GHA.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07% :tada:

Comparison is base (474bc68) 93.63% compared to head (1677204) 93.71%. Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #95 +/- ## ========================================== + Coverage 93.63% 93.71% +0.07% ========================================== Files 7 7 Lines 330 334 +4 ========================================== + Hits 309 313 +4 Misses 21 21 ``` | [Files Changed](https://app.codecov.io/gh/tfoxy/graphene-django-optimizer/pull/95?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tom%C3%A1s+Fox) | Coverage Δ | | |---|---|---| | [graphene\_django\_optimizer/query.py](https://app.codecov.io/gh/tfoxy/graphene-django-optimizer/pull/95?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tom%C3%A1s+Fox#diff-Z3JhcGhlbmVfZGphbmdvX29wdGltaXplci9xdWVyeS5weQ==) | `92.10% <100.00%> (-0.03%)` | :arrow_down: | | [graphene\_django\_optimizer/utils.py](https://app.codecov.io/gh/tfoxy/graphene-django-optimizer/pull/95?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Tom%C3%A1s+Fox#diff-Z3JhcGhlbmVfZGphbmdvX29wdGltaXplci91dGlscy5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tfoxy commented 1 year ago

@sjdemartini we now have CI working correctly. Didn't check if publishing works. It's almost the same config as graphene-django and I added the secret, so hopefully it works.

I used the same versions and tools of the Travis config to break things as little as possible and to have it working ASAP. But feel free to change anything in the future if it makes things easier/better.

sjdemartini commented 1 year ago

Amazing, thank you @tfoxy! Really appreciate you getting this in place and for releasing the version update. I'll test it out in my project next week 😄