search

tfpauly / privacy-proxy

Specifications for Privacy Proxy Implementations
Other
29 stars 11 forks source link

Fix and unify issue-key name across docs #132

Closed chris-wood closed 2 years ago

chris-wood commented 2 years ago

Closes #131

tfpauly commented 2 years ago

Hm, I'm not sure I prefer "token-issuance-key" to "issuer-key". What's wrong with the issuer-key naming, since it's shorter and seems pretty clear still?

chris-wood commented 2 years ago

My claim is that it's not really clear. The issuer has many keys in its possession, including origin name encryption key, token issuance keys (private keys), token validation keys (public keys), and so on. I think we ought to be specific with what this thing is. Maybe that's not "token-issuance-key" (since it's really the validation key), but it's certainly not "issuer-key".

tfpauly commented 2 years ago

Commented on the issue. I still prefer the simpler name here. I agree that "token-issuance-key" isn't correct, since it sounds more like a private key. The key we're talking about is the common one that all clients and origins see for all token types, which is why I think a generic name like "issuer key" is appropriate.

tfpauly commented 2 years ago

Discussed on call, change to "token-key"

chris-wood commented 2 years ago

Closing in favor of #138.