search

tfreedman / explorer

An open source cryptocurrency block explorer
MIT License
8 stars 18 forks source link

Re-check invalid transactions #4

Closed tfreedman closed 6 years ago

tfreedman commented 6 years ago

Right now, if a transaction isn't understood by the current parser, it gets thrown into the InvalidTransactions table and ignored. There are many reasons why transactions can be thrown into that table, and not all of them are "the transaction is actually invalid". For example, if the indexer was able to retrieve a list of transactions from a block, but then bitcoind crashed, it will put every transaction into the InvalidTransactions table, because attempting to parse it will result in an error (that bitcoind is down). Likewise, when Litecoin added SegWit support, the explorer no longer understood the transaction format for new transactions, and subsequently placed them all in the InvalidTransactions table so that it could continue indexing what it understood.

This bug isn't about the fact that things are thrown into the InvalidTransactions table - it's about not re-checking those transactions in the future, in case a future explorer version has added support for something that was previously invalid. Future indexers should attempt to re-validate those transactions every so often, so that anything placed there by accident goes back into the main pile.

tfreedman commented 6 years ago

This was fixed a few updates ago.