tfriedel / python-lightify

Python module for Osram lightify. This is a work in progress.
Apache License 2.0
18 stars 9 forks source link

Add light.alpha() method #20

Open durera opened 5 years ago

durera commented 5 years ago

I can use the various accessor methods for all properties, except alpha. For alpha I need to to use raw_values tuple, would be nice to add aplha() to the Light class to avoid need to handle raw_values(), e.g. to avoid something like this:

            # Alpha is only available from raw_values()
            (onoff, lum, temp, red, green, blue, alpha) = light.raw_values()

            # if online is false then override on to be false, the light can't be on if it's not even powered on 
            state = {
                "online": light.reachable(),
                "lastSeen": light.last_seen(),
                "on": (light.reachable() and light.on()),
                "lum": light.lum(),
                "temp": light.temp(),
                "colour": {
                    "red": light.red(),
                    "green": light.green(),
                    "blue": light.blue()
                },
                "alpha": alpha
            }
OleksandrBerchenko commented 5 years ago

No problem, I will add the alpha method.

Well, the main question is: how do you use that value? :) From my experience, it never changes (that's why it's not exposed). Could you please explain your case?

Thanks!

OleksandrBerchenko commented 5 years ago

@durera So, is that property actual for all device types or just for some particular ones? Do I need to preserve int or to convert it to bool?

Thanks!