search

tfsaggregator / aggregator-cli

A new version of Aggregator aiming at Azure DevOps (ex Visual Studio Team Services)
https://tfsaggregator.github.io/
Apache License 2.0
73 stars 32 forks source link

Document required PAT permissions #133

Closed WilliamRitson closed 4 years ago

WilliamRitson commented 4 years ago

The documentation mentions what role the service principal needs but as far as I can tell it doesn't say what permissions the ADO PAT requires.

It would be nice to document the minimum permissions that the PAT requires so the aggregator can be set up in line with the principle of least privilege.

RSMJreck commented 4 years ago

The document at https://github.com/tfsaggregator/aggregator-cli/blob/master/doc/setup.md covers what scopes the PAT needs.

WilliamRitson commented 4 years ago

Thanks. That answers my question. I think it may be valuable to link to that page from the readme https://github.com/tfsaggregator/aggregator-cli/blob/master/README.md

giuliov commented 4 years ago

I have an idea to refactor and publish this material on https://tfsaggregator.github.io/ wiki-style so you can improve it. Do you, @WilliamRitson, it would be a good idea ?

WilliamRitson commented 4 years ago

@giuliov That could be helpful and make it small changes to the wiki. But the documentation itself looks pretty good to me, my issue was I didn't notice that there was more documentation beyond what was linked to by the readme. So just adding a link to it could help.

giuliov commented 4 years ago

Can you take a look at https://tfsaggregator.github.io/docs/v3/

WilliamRitson commented 4 years ago

It looks good to me @giuliov one small nitpick there seem to be some broken images on the page https://tfsaggregator.github.io/docs/v3/setup/production/

giuliov commented 4 years ago

good catch, fixed, thanks.