Avoid recompiling rules on every call

tfsaggregator / aggregator-cli

A new version of Aggregator aiming at Azure DevOps (ex Visual Studio Team Services)

https://tfsaggregator.github.io/

Apache License 2.0

74 stars 32 forks source link

Avoid recompiling rules on every call #242

Closed aok-foss closed 2 years ago

aok-foss commented 3 years ago

Currently the rule code is compiled on every execution. Apart from performance impact of the compilation, this results in process private bytes growing on every execution as the dynamically compiled assemblies are never unloaded. After a number of executions, they start failing with an OutOfMemoryException.

This change does not fix the memory leak but it does make sure the rules are not recompiled unless they changed, so the leaking rate does not depend on number of rule executions.

giuliov commented 3 years ago

Thank you! I started working on this PR in the weekend but I need a little more time to add some tests.

giuliov commented 2 years ago

Included in release v1.2.