search

tfsbuildextensions / BuildManager

Community TFS Build Manager
54 stars 27 forks source link

Definition wont import with AdvancedTestSettings or AdvancedBuildSettings #4

Closed antxxxx closed 9 years ago

antxxxx commented 9 years ago

I exported a definition that uses the default template for git (GitTemplate.12.xaml process) and I can not import it back in - I get an error saying invalid cast specification. The error seems to be in the AdvancedTestSettings and AdvancedBuildSettings in the ProcessParameters section. If I remove them from the exported definition, I can import the definition back in (though obviously I dont have the settings set in these sections) This is the part of the exported definition that is causing problems

"ProcessParameters": {
    "AdvancedTestSettings": {
      "Json": "{\"DisableTests\":true,\"PreActionScriptPath\":\"\",\"PreActionScriptArguments\":\"\",\"PostActionScriptPath\":\"\",\"PostActionScriptArguments\":\"\"}"
    },
    "AdvancedBuildSettings": {
      "Json": "{\"MSBuildArguments\":\"/p:TargetFrameworkVersion=\\\"v3.5\\\"\",\"MSBuildPlatform\":\"X86\",\"PreActionScriptPath\":\"\",\"PreActionScriptArguments\":\"\",\"PostActionScriptPath\":\"\",\"PostActionScriptArguments\":\"\",\"RunCodeAnalysis\":\"AsConfigured\"}"
    }
}
mikefourie-zz commented 9 years ago

fixed here https://github.com/tfsbuildextensions/BuildManager/commit/54b54a22523fe2993e0dad306f8ba28e72cef2c0