tfussell / xlnt

:bar_chart: Cross-platform user-friendly xlsx library for C++11+
Other
1.5k stars 423 forks source link

Clarify target C++ language standard #295

Open Crzyrndm opened 6 years ago

Crzyrndm commented 6 years ago

@tfussell Is this library targeting C++11 or C++14? The readme compile command and repo description state 14, but the cmake files are set to 11 (https://github.com/tfussell/xlnt/blob/master/source/CMakeLists.txt#L7).

Crzyrndm commented 6 years ago

I've been thinking about this and I can't find a significant benefit to this library targeting 14. The major bonus in my experience is the dramatically improved usability of constexpr (which doesn't help much in file IO).

Locations where c++14 is mentioned (could be more external)

Github

Repository (git grep c++14 (ignoring third party))

External

tfussell commented 6 years ago

That's very thorough! I don't want the library to "feel" outdated, but I agree that C++11 is probably a good target for the time being. Some users were reporting problems with C++14 features so I added C++11 workaround and only halfway updated docs. Once more distros support C++14+ with their built in compilers we can move to a later standard. I'll go through and update docs/comments/etc in the noted places.