search

tfussell / xlnt

:bar_chart: Cross-platform user-friendly xlsx library for C++11+
Other
1.49k stars 418 forks source link

missing_number_format class is not building with clang 11.0.0 #480

Open romaniy173 opened 4 years ago

romaniy173 commented 4 years ago

Hey,

I have an issue while building on OSX with clang 11.0.0. The exact error :

xlnt/include/xlnt/utils/exceptions.hpp:117:40: Default constructor of 'missing_number_format' is implicitly deleted because base class 'xlnt::exception' has no default constructor

The issue here is that class exception doesn't have default constructor, so there is impossible to build with this class. Also this class is not actually using anywhere, is there possible either comment it out(working just fine without it) or add constructor argument so it could build?

Thanks!

tfussell commented 4 years ago

I have noticed similar issues in the past building on newer compilers. I'll knock this out in my next round of fixes soon. Thanks for reporting.

romaniy173 commented 4 years ago

Well, thank you for doing this! Looking forward for this fix, let me know if you want me to make a PR for fixing this and in any way which is appropriate. Thanks