beached commented 2 years ago

Limits isn't being transitively included on gcc 11.2.0/ubuntu. Added as it produces an error

TheLavaBlock commented 2 years ago

Thanks, looking forward to the fix

Adela0814 commented 2 years ago

@mfsv Is this ready to merge?

mfsv commented 2 years ago

Absolutely!

------ Originalnachricht ------ Von: "Mengna Li" @.> An: "tfussell/xlnt" @.> Cc: "Markus Färber" @.>; "Mention" @.> Gesendet: 19.07.2022 03:48:01 Betreff: Re: [tfussell/xlnt] Missing include in number_formatter.cpp (PR

617)

@.*** https://github.com/mfsv Is this ready to merge?

— Reply to this email directly, view it on GitHub https://github.com/tfussell/xlnt/pull/617#issuecomment-1188505435, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACALQQMNB7VY5YHRXYKD44TVUYCNDANCNFSM5RDCMTDA. You are receiving this because you were mentioned.Message ID: @.***>

tfussell commented 2 years ago

Thanks for the contribution and sorry it took so long to get merged.

tfussell / xlnt

Missing include in number_formatter.cpp #617

617)