search

tfussell / xlnt

:bar_chart: Cross-platform user-friendly xlsx library for C++11+
Other
1.45k stars 406 forks source link

option OFF by default for building test executable #659

Closed ThibaultDECO closed 1 year ago

ThibaultDECO commented 2 years ago

It seems better to leave the option OFF by default for building test executable

ThibaultDECO commented 2 years ago

I have no idea why it doesn't pass the checks, it works perfectly fine for me...

tfussell commented 1 year ago

This is because AppVeyor (the CI xlnt uses for testing builds with MSVC) tries to run the tests which aren't generated with this disabled by default. If you change this line from - cmake -G "Visual Studio 14 2015" -D CMAKE_GENERATOR_PLATFORM=%platform% -D STATIC=%STATIC% -D SAMPLES=ON -D BENCHMARKS=ON .. to - cmake -G "Visual Studio 14 2015" -D CMAKE_GENERATOR_PLATFORM=%platform% -D STATIC=%STATIC% -D SAMPLES=ON -D BENCHMARKS=ON -D TESTS=ON .. in your PR, it should build fine. We'll need the same change in the CircleCI config as well.

I'll merge the PR if you don't mind making those changes.

ThibaultDECO commented 1 year ago

Ok, thanks, done!