Open luco5826 opened 1 year ago
Hi! I've stumbled upon a segmentation fault while loading an XLSX exported with Libreoffice.
Unluckily the document is under NDA but I've found the culprit and it is this instruction
In particular, when relative contains a relative path that starts with an .., the second if tries to pop_back() an empty vector and crashes
relative
..
pop_back()
This snippet fixes the issue but I'm not sure it is functionally the same as before
if (component == "..") { if (absolute_parts.size() > 0) { absolute_parts.pop_back(); } continue; }
I've plugged this code in and it seems to pass all the tests, feel free to raise a PR if you want.
Hi! I've stumbled upon a segmentation fault while loading an XLSX exported with Libreoffice.
Unluckily the document is under NDA but I've found the culprit and it is this instruction
In particular, when
relative
contains a relative path that starts with an..
, the second if tries topop_back()
an empty vector and crashesThis snippet fixes the issue but I'm not sure it is functionally the same as before