Open doomlaur opened 1 year ago
This issue would be fixed by merging #686
Just for the record: because I did not need support for the definedNames
introduced in Pull Request #650, I was able to fix my issues some time ago by simply compiling XLNT from the last commit made before the pull request has been merged. To be precise, I compiled XLNT from commit f1107a5b0f32857e40d17ab4989009ad92377c1e made on August 13, 2022 at 22:21:48. So I simply did a checkout in Git exactly to that commit and compiled XLNT from it, excluding the commits after it. In case you don't need definedNames
, you can do the same - otherwise, Pull Request #686 should fix the issues (but, to be honest, I did not test it myself yet).
I tested XLNT with some test files and noticed issues with the following file I downloaded from the internet: EBA Validation Rules March 2020 deactivation.xlsx
I got the following exception:
xl/workbook.xml:2:2581: error: attribute 'localSheetId' expected
In
xl\workbook.xml
the following piece of XML causes issues:The part that causes issue is that XLNT requires
localSheetId
to exist, while according to the official ECMA-376 that XML attribute is optional:To be precise, the following code in
xlsx_consumer::read_office_document
(which has been introduced in this pull request) causes issues:Could you please fix this bug before releasing XLNT 1.6? Thank you for developing this great library! 😃