search

tfutils / tfenv

Terraform version manager
MIT License
4.52k stars 454 forks source link

tfenv downloading Linux binaries on Cygwin #381

Closed ElvenSpellmaker closed 9 months ago

ElvenSpellmaker commented 1 year ago

Hey I believe this worked in the past but now tfenv is downloading Linux binaries from Cygwin.

From the ~/.tfenv/libexec/tfenv-install script I notice this on line 95:

  CYGWINNT*)
    kernel="windows";
    ;;

However uname -s for Cygwin produces:

$ uname -s
CYGWIN_NT-10.0-19044

It seems to have been changed from CYGWIN_NT* to CYGWINNT* in this commit: https://github.com/tfutils/tfenv/commit/0a60714de58fe4abcf43afe61e44a1f86ba7f499 I'm not sure this was intentional? (Also note how MSYS_NT* changes to MSYSNT* too)

(Also as a side point the binaries it does download are missing x and so manual intervention is always required, a quick chmod u+x after downloading on the terraform.exe would be nice)