search

tfuxu / Halftone

Give your images that pixel art-like style
GNU General Public License v3.0
97 stars 16 forks source link

Reduce minimal width to 360px for mobile support #45

Closed 1peter10 closed 9 months ago

1peter10 commented 10 months ago

Hi,

I have just tried your great app on the Librem 5 and it's working quite well (when applying the scale-to-fit "hack" that makes too wide apps fit the screen in Phosh) on mobile already, and I am really glad to see more work regarding mobile support in #44 !

360px would be the correct value due to 2x scaling on a 1440x720px screen (or 3x on 1080px wide screens when held in portrait)

See https://developer.gnome.org/hig/guidelines/adaptive.html for reference.

(BTW, if you have input to make https://linuxphoneapps.org/docs/resources/developer-information/ better, please get in touch :) )

Here's how the app looks as is:

Without any tweaks

And here in it's current form with scale-to-fit

With scale-to-fit

Menu with scale-to-fit

I am happy to help with testing, unfortunately (day job) it may take me a bit to give proper feedback.

tfuxu commented 10 months ago

I fixed this issue, now the window should properly scale to the recommended 360px.

The culprit here was an unused successful dithering report page, which for some reason made the whole window structure require an additional 100 pixels from the already set 360px.

Also, thanks for linking linuxphoneapps's docs, its a pretty useful resource! PS. Please don't close this issue, I'll close it myself when I'll finish making the fix.