search

tfwillems / HipSTR

Genotype and phase short tandem repeats using Illumina whole-genome sequencing data
GNU General Public License v2.0
94 stars 31 forks source link

Building using releases #40

Closed cking-ha closed 7 years ago

cking-ha commented 7 years ago

It appears as if the process of building via releases is broken. Specifically, the Makefile uses git to determine the version, but the releases lack a functioning git repo to determine the version from.

tfwillems commented 7 years ago

Thanks for pointing this out. I hadn't noticed this issue as we recommend users install using git clone which will automatically construct the required git repo. However, as you pointed out, the git information isn't correctly populated when you use the github release link.

I've gone ahead and modified the Makefile such that this should no longer be an issue. I've constructed a new release (v0.5) that contains this fix and many others, so building using the release for v0.5 should now work correctly.

Let me know if you have any issues