tfwright / live_admin

Low-config admin UI for Phoenix apps, built on LiveView
MIT License
248 stars 22 forks source link

Suggestion: move buttons and summary outside of table #106

Closed tmaszk closed 3 months ago

tmaszk commented 3 months ago

Describe the bug This is a suggestion, not a bug. I hope you don't mind. I think you have a great package here and my goal is only to help improve it.

When viewing a table, the Prev/Next buttons and "XX total rows" are rendered inside the table. When the rows are large, this prevents you from accessing the buttons or seeing the total number of records without having to scroll all the way to the right or left.

I would rather see those buttons and row total rendered outside the table so I could see both without having to horizontally scroll.

To Reproduce Steps to reproduce the behavior:

  1. Go to a table with enough fields that the table has to horizontally scroll to see the entire record.
  2. Notice that the buttons are only visible if you scroll all the way to the left, while the total number of rows is only visible if you scroll all the way to the right.

Expected behavior See buttons and row total without having to scroll.

Screenshots Screenshot 2024-03-13 at 9 32 09 AM Screenshot 2024-03-13 at 9 32 37 AM Screenshot 2024-03-13 at 9 32 54 AM

Environment:

Additional context Thanks!

tfwright commented 3 months ago

Hi again @tmaszk

I am happy to consider that. I can't recall any particular reason they are in the table currently. Would you mind reopening this issue in the discussions tab? I am currently only using issues for bugs: https://github.com/tfwright/live_admin/discussions