search

tfwright / live_admin

Low-config admin UI for Phoenix apps, built on LiveView
MIT License
251 stars 22 forks source link

Updates for LiveView 0.18.x #12

Closed harmon25 closed 1 year ago

harmon25 commented 1 year ago

Biggest change between 0.17 -> 0.18 seems to be moving some functions around.

assigns + assigns new now belong to Phoenix.Component instead of Phoenix.LiveView

this change addresses that, but there are still some new warnings warnings, all tests are passing

jmillxyz commented 1 year ago

Hi there! I was going to open a similar PR, any chance of getting this merged to fix warnings for LiveView 0.18 installations?

tfwright commented 1 year ago

Hi @jmillxyz Not sure exactly how close this is to being ready. It doesn't look like there have been any recent changes, but I wanted to check into possible backwards compatibility before merging.

Are you using a current release of LiveAdmin with LiveView 0.18? Have you run into any issues besides warnings?

jmillxyz commented 1 year ago

I'm using a branch of LiveAdmin 0.5 with one LiveView 0.18.11 app, and a branch of LiveAdmin 0.6 for another. Admittedly I'm not making use of all of LiveAdmin's features (e.g. not using prefix_options, or most of the resource-specific options), mostly as a simple DB viewer.

IIRC LiveAdmin won't actually compile because of some of the changes in LV 0.18, like the Phoenix.Component change @harmon25 mentioned.

tfwright commented 1 year ago

0.7 has been released with support for LV 0.18