search

tfwright / live_admin

Low-config admin UI for Phoenix apps, built on LiveView
MIT License
258 stars 25 forks source link

Fix Ecto repo config in README.md.eex #60

Closed stefanluptak closed 1 year ago

stefanluptak commented 1 year ago

The info provided was not correct. That would only work after using mix release. With the config set in the config/config.exs it is working in all environments.

tfwright commented 1 year ago

Hi @stefanluptak !

Can you provide a little more information about the error you ran into, or even better, provide a sample repo demonstrating the issue? Because I am very confident runtime config should be fine for this since it is only accessed at runtime, and I am and have been using runtime config for it since first writing it, including in dev where mix release is not involved. AFAIK there is no connection between elixir's runtime.ex and mix releases

stefanluptak commented 1 year ago

Hi @tfwright. Now I realized I put that config ... inside the if config_env() == :prod do ... end block and didn't notice that. 🤦🏻 Sorry. I am closing this PR as irrelevant.

tfwright commented 1 year ago

No worries! Better wontfix bug reports than no bug reports