Add Account/Character Macro feature.

[pgarneau]

• Myslot now exports EVERYTHING always as this information can be useful for Action bars even if macros are being ignored on import
• Ignore options now support account vs character macros separately
• Ignore options ONLY apply to the import and do not prevent a CLEAR
• Added option to clear Account/Character macros seprarately
• Updated UI to be more UX friendly with a smaller text window and clear checkboxes for options
• Added some error handling on the Action Bar import where a macro could possibly not be found
• Checked options are now saved PER CHARACTER for easy reuse of the addon

[pgarneau]

@tg123 Made a separate PR cause I changed some logic around. I do think this is the best UX of the UI we're gonna get. Dropdowns are too "hidden" when you press import.

I will close my other PR, but I still have the branch

[tg123]

the reason ignore applies to export is that people may wish to hide their macro or something else. this option will also contribute to smaller exported text

[pgarneau]

The end result is the same if you ignore on export or ignore on import. THe size of the exported text is really a concern?

[tg123]

people can decode exported text to get macro if it contains everything and many people use it for sharing macro only

[pgarneau]

Yes but it’s kinda necessary in this use case:

You import action bars, but ignore account macros because you already have them.

The action bar import relies on the macro table to find the macro with index X.

If you didnt modify your account macros, you can use the index directly to translate to macroId.

However if you did modify macros, you can use the macro table with the MySlot:FindMacro() to find the new index EVEN IF you decided to ignore it

On Sat, Jun 15, 2024 at 2:41 AM Boshi Lian @.***> wrote:

people can decode exported text to get macro if it contains everything and many people use it for sharing macro only

— Reply to this email directly, view it on GitHub https://github.com/tg123/myslot/pull/49#issuecomment-2169163776, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADR4JCX5PPUNJ5JDC4BWDV3ZHPO3JAVCNFSM6AAAAABJKPVLHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRZGE3DGNZXGY . You are receiving this because you authored the thread.Message ID: @.***>

[pgarneau]

And yes people use the string to share macros, sometimes use it to share whole UIs.

We already have very long import strings in other addons like elvui/weakauras/etc

I still dont see how it is a problem

[tg123]

[pgarneau]

I don't like how the configuration is hidden when you click on import or export.

It is cleaner though.

[tg123]

please check branch optref (WIP)

[tg123]

Thanks

Your PR inspired me a lot, for example your FindMacro fixed long time duplicate macro issue. I copied it Also, I rethought about your question if macro should be export: that the reason you want to keep macro info is that ignore macro during import would stop myslot looking up local macro table, the latest version also fixed it.

Please let me know if https://www.curseforge.com/wow/addons/myslot/files/5485299 solved all your headache problems

too busy at day time work, sorry for the delay.

[pgarneau]

@tg123 ty I'll check out your latest release