tg123 / myslot

The missing layout/keybinding/macro exportor for World of Warcraft
https://myslot.net/
Apache License 2.0
46 stars 20 forks source link

Lua error 5.17.0 #53

Closed zeenk closed 4 months ago

zeenk commented 4 months ago

1x Myslot/gui.lua:307: attempt to concatenate global 'ACTIONBAR_LABEL' (a nil value) [string "@Myslot/gui.lua"]:307: in function `CreateSettingMenu' [string "@Myslot/gui.lua"]:379: in main chunk

Locals: opt =

{ ignorePetActionBar = false ignoreActionBars =
{ } ignoreBinding = false ignoreMacros =
{ } } tableref = defined @Myslot/gui.lua:69 childchecked = defined @Myslot/gui.lua:83 childclicked = defined @Myslot/gui.lua:87 parentchecked = defined @Myslot/gui.lua:93 parentclicked = defined @Myslot/gui.lua:104 actionbarlist =
{ 1 =
{ } 2 =
{ } 3 =
{ } 4 =
{ } 5 =
{ } 6 =
{ } 7 =
{ } 8 =
{ } 9 =
{ } 10 =
{ } 11 =
{ } 12 =
{ } 13 =
{ } } (temporary) =
{ } (temporary) =
{ hasArrow = true checked = defined @Myslot/gui.lua:93 notCheckable = false isNotRadio = true func = defined @Myslot/gui.lua:104 arg1 = "action" keepShownOnClick = true menuList =
{ } } (temporary) =
{ checked = defined @Myslot/gui.lua:272 keepShownOnClick = true notCheckable = false text = "Key Binding" func = defined @Myslot/gui.lua:269 isNotRadio = true } (temporary) =
{ hasArrow = true checked = defined @Myslot/gui.lua:93 notCheckable = false text = "Macro" func = defined @Myslot/gui.lua:104 arg1 = "macro" keepShownOnClick = true menuList =
{ } isNotRadio = true } (temporary) =
{ } (temporary) = "Pet" (temporary) = " " (temporary) = nil (temporary) = "%s Specific Macros" (temporary) = "" (*temporary) = "attempt to concatenate global 'ACTIONBAR_LABEL' (a nil value)" menuFrame = Frame { 0 = Text = UIParentText { } Icon = UIParentIcon { } Button = UIParentButton { } Right = UIParentRight { } Middle = UIParentMiddle { } Left = UIParentLeft { } } L =
{ Stance Action Bar = "Stance Action Bar" Key Binding = "Key Binding" Myslot = "Myslot" Main Action Bar Page = "Main Action Bar Page" Ignore during Import = "Ignore during Import" Close = "Close" Import = "Import" }

tg123 commented 4 months ago

may i know your wow version?

zeenk commented 4 months ago

Retail, the error happens when you load into the game, and the /myslot command doesn't work, previous version works with no errors so yeah, something went wrong in this update.

hewozuoai commented 4 months ago

the export/import options for ignoring the main action bars are also not visible due to same issue on https://github.com/tg123/myslot/blob/master/gui.lua#L254 (but no error generated as its not concatenating the text, just setting it to nil)

hewozuoai commented 4 months ago

i think it should be ACTIONBARS_LABEL image

after making change ACTIONBAR_LABEL to ACTIONBARS_LABEL on L254 and L307

image image image

tg123 commented 4 months ago

Thanks 5.17.1 published