tg123 / myslot

The missing layout/keybinding/macro exportor for World of Warcraft
https://myslot.net/
Apache License 2.0
46 stars 20 forks source link

Duplication of General Macros #70

Open Surarn opened 1 week ago

Surarn commented 1 week ago

Im using macros that are named "0PI","0Rescue","0Innervate" etcetc that have their contents changed from another macro, so if i mouseover a person and press my "PiChangeMacro" it puts that units name in "0PI".

Problem with those "0PI" macros are that if the content of the macros have changed since the Myslot export, Myslot creates a duplicate of those with the same name which makes it so the changing macro cant identify the correct one and me myself have no idea which of the macros are the "true" macro that i wanna keep and which are the "false" that i wanna delete, deleting the wrong one removes them from all my characters that use them which is a big pain.

Chosing to ignore general or specifik macros results in myslot not dragging the macro on the bar.

Guess its a niche case of Myslot determines the identity of the macro by the body of the macro and not just the name, i guess what im after is "Does macro name XXXX already exists? Yes->Drag it on the bar, No->Create it then drag it on the bar".

Surarn commented 1 week ago

Okey, it was kinda easy changing MySlot:FindMacro, i dont know if this is a issue that others also have, if not i guess we can mark this with solved if this isnt something you are interested in including/changing.

tg123 commented 1 week ago

i wonder what is the content of macro

myslot will try to search macro matches not only titles but also content

or maybe a pr can help me understand the issue better

On Sun, Nov 3, 2024 at 05:05 Surarn @.***> wrote:

Okey, it was kinda easy changing MySlot:FindMacro, i dont know if this is a issue that others also have, if not i guess we can mark this with solved if this isnt something you are interested in including/changing.

— Reply to this email directly, view it on GitHub https://github.com/tg123/myslot/issues/70#issuecomment-2453421300 or unsubscribe https://github.com/notifications/unsubscribe-auth/AABJTPQ2MEZDVJIXOZEAHYLZ6YNQZBFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLLDTOVRGUZLDORPXI6LQMWWES43TOVSUG33NNVSW45FGORXXA2LDOOJIFJDUPFYGLKTSMVYG643JORXXE6NFOZQWY5LFU4YTCOBYGQ4DBAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDENRTGEYTIMRQGA32O5DSNFTWOZLSUZRXEZLBORSQ . You are receiving this email because you are subscribed to this thread.

Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .