tg44 / OctoPrint-Prometheus-Exporter

An octoprint plugin for prometheus compatible metrics endpoint
MIT License
47 stars 21 forks source link

Rename metrics #33

Open loelkes opened 1 year ago

loelkes commented 1 year ago

I would like to rename and restructure the metrics so that the naming corresponds more to the OctoPrint namespace and follows some Prometheus best practices

  1. Add units where they are fixed.
  2. Follow Octoprint namespace. For example use keyword job instead of print for print jobs.
  3. Organize in categories printer, job, jobs and server

Examples:

No units to be set for distances and temperatures since Marlin (and others?) support Fahrenheit or Inches as well IIRC.

This would lead to version 3, since it is a breaking change. Please let me know if you @tg44 agree with the global direction and I'll prepare a PR.

tg44 commented 1 year ago

I think its a good direction.