tg44 / OctoPrint-Prometheus-Exporter

An octoprint plugin for prometheus compatible metrics endpoint
MIT License
47 stars 21 forks source link

Fix print time metrics not being cleared correctly #41

Open hyperair opened 8 months ago

hyperair commented 8 months ago

This fixes an issue where print time metrics for a path that has completed don't get fully cleared after print completion

arcnmx commented 2 months ago

Trying this seemed to result in an error after a cancel?

Exception in thread Thread-102: TypeError: PrometheusExporterPlugin.print_deregister_callback() takes 2 positional arguments but 51 were given Exception in thread Thread-106: TypeError: PrometheusExporterPlugin.print_deregister_callback() missing 1 required positional argument: 'label'

hyperair commented 2 months ago

Oops, just fixed that